Re: Quoting of *_command arguments - Mailing list pgsql-docs

From Peter Eisentraut
Subject Re: Quoting of *_command arguments
Date
Msg-id 97c4fe46-0c52-4fe8-90d3-10da182e587c@eisentraut.org
Whole thread Raw
In response to Quoting of *_command arguments  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Quoting of *_command arguments
List pgsql-docs
On 11.11.25 20:31, Bruce Momjian wrote:
> We inconsistently double-quote the "%f" and "%p" arguments of
> "archive_command" and "restore_command".  Paths with spaces or special
> characters, especially directory names in these cases, would need
> double-quotes.
> 
> This patch adds double-quotes to all instances.  I can also go the other
> way and remove them all, but we should be consistent.

I think %f doesn't need to be quoted because it will only contain 
certain characters, but if we tried to clarify that it would probably be 
too confusing.  It makes sense to nudge people that some quoting is prudent.

Your patch looks good to me.




pgsql-docs by date:

Previous
From: Bruce Momjian
Date:
Subject: Quoting of *_command arguments
Next
From: Bruce Momjian
Date:
Subject: Re: Quoting of *_command arguments