Re: Use CASEFOLD() internally rather than LOWER() - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: Use CASEFOLD() internally rather than LOWER()
Date
Msg-id 9e5b70b6a45166e42b1a878e260dd2e1c76be506.camel@j-davis.com
Whole thread Raw
In response to Re: Use CASEFOLD() internally rather than LOWER()  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
On Tue, 2026-01-13 at 10:14 +0800, Chao Li wrote:
> 1 - 0001
> ```
> +SELECT U&'straße' ILIKE U&'STRASSE' COLLATE PG_C_UTF8;
> ```
>
> Do we want to added one more test:
> ```
> SELECT U&'straße' ILIKE U&'STRASSE' COLLATE PG_UNICODE_FAST;
>  ?column?
> ----------
>  t
> (1 row)
> ```
> Which tests the different behaviors against collations.

I am confused, doesn't the patch already have both of those tests for
both collations? What change are you suggesting?

> I initially thought to add test cases with different collations, but
> after debugging, I found that citext intentionally ignores specified
> collation.

Adding a test that's dependent on the database-wide collation is more
heavyweight because it needs to create a new database.


Regards,
    Jeff Davis




pgsql-hackers by date:

Previous
From: Kai Wagner
Date:
Subject: Re: how to gate experimental features (SQL/PGQ)
Next
From: Jeff Davis
Date:
Subject: Re: Remove redundant assignment in CreateWorkExprContext