Re: Remove redundant assignment in CreateWorkExprContext - Mailing list pgsql-hackers

From Chao Li
Subject Re: Remove redundant assignment in CreateWorkExprContext
Date
Msg-id A2B017FC-7E8D-4EAD-901A-DED4F21A65C9@gmail.com
Whole thread Raw
In response to Re: Remove redundant assignment in CreateWorkExprContext  (Andreas Karlsson <andreas@proxel.se>)
List pgsql-hackers

> On Jan 14, 2026, at 15:13, Andreas Karlsson <andreas@proxel.se> wrote:
>
> On 8/21/25 5:47 AM, Chao Li wrote:
>> While discussing [1], I was reading execUtils.c, then I noticed this redundant local variable assignment in
CreateWorkExprContext().The attached patch fixed that. 
> Nice spotted but I think your patch reduces readability. How about this?
>
> Andreas
> <v2-0001-Remove-redundant-assignemnt-in-CreateWorkExprCont.patch>

Hi Andraes,

Thank you very much for reviewing and bumping this patch. I’m fine with your tuning; I don’t have a strong preference,
soI’m happy to leave the final decision to the committers. 

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Use correct macro for accessing offset numbers.
Next
From: Oleg Tselebrovskiy
Date:
Subject: Re: 001_password.pl fails with --without-readline