Re: Binary support for pgoutput plugin - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Binary support for pgoutput plugin
Date
Msg-id A2BD2917-29EC-42E9-AB6E-9B1BB0F6DB7E@yesql.se
Whole thread Raw
In response to Re: Binary support for pgoutput plugin  (Dave Cramer <davecramer@gmail.com>)
Responses Re: Binary support for pgoutput plugin
List pgsql-hackers
> On 2 Jul 2020, at 18:41, Dave Cramer <davecramer@gmail.com> wrote:
>
> rebased

Thanks!  The new version of 0001 patch has a compiler warning due to mixed
declarations and code:

worker.c: In function ‘slot_store_data’:
worker.c:366:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
     int cursor = tupleData->values[remoteattnum]->cursor;
     ^
worker.c: In function ‘slot_modify_data’:
worker.c:485:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
     int cursor = tupleData->values[remoteattnum]->cursor;
     ^

I didn't investigate to see if it was new, but Travis is running with Werror
which fails this build.

cheers ./daniel


pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: proposal: possibility to read dumped table's name from file
Next
From: Daniel Gustafsson
Date:
Subject: Re: vacuum verbose detail logs are unclear; log at *start* of each stage