Home > mailing lists

Question about an inconsistency - 3 - Mailing list pgsql-hackers

From	petrum@gmail.com
Subject	Question about an inconsistency - 3
Date	July 19, 2016 21:15:21
Msg-id	AF0BCA9A-E3F7-4A82-AC7B-6874074C72D7@gmail.com Whole thread Raw
In response to	Question about an inconsistency - 2 ("petrum@gmail.com" <petrum@gmail.com>)
Responses	Re: Question about an inconsistency - 3
List	pgsql-hackers

Hi,

In file postgres/postgresql-9.4.4/src/timezone/zic.c

function stringzone line 2091we have

if (stringrule(result, stdrp, dstrp->r_stdoff, zp->z_gmtoff) != 0)

Is it ok to have as the 3rd argument dstrp->r_stdoff or should we

have stdrp->r_stdoff? In line 2085 dstrp is used in both arguments.

Not very sure because I do not understand the semantics of the

invoked operation, but I thought it would be better to ask.

Thanks,

Petru Florin Mihancea

From: "petrum@gmail.com"
Date: 19 July 2016, 21:15:11
Subject: Question about an inconsistency - 2

From: Andres Freund
Date: 19 July 2016, 21:25:06
Subject: Re: An unlikely() experiment