Object translation mechanism is, umm, broken. - Mailing list pgadmin-hackers

From Dave Page
Subject Object translation mechanism is, umm, broken.
Date
Msg-id BANLkTi=8CMrdDtMtHD4si8y3+CLONfT1xQ@mail.gmail.com
Whole thread Raw
Responses Re: Object translation mechanism is, umm, broken.
List pgadmin-hackers
Hi Guillaume,

This commit: http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=4b8ae9d82c3b879eb02dda60908ed9590a674ec4
(particularly the code in pgObject.cpp) is causing problems. I keep
running into objects for which we now get messages like "Refreshing
unknown object of type Replication", which I believe used to work just
fine. I've just hit it with the Slony replication cluster object, and
now have a sneaking suspicion it's also going to affect all the other
slony object types.

Aside from the fact that the code is incomplete, it's a serious
modularity violation. We shouldn't have a giant conditional statement
in a parent class that has knowledge of each of the different classes
that might be derived from that object. Instead, each of the child
classes should override a common function.

Can you look at this please?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Luis Ochoa
Date:
Subject: Database Designer for pgAdmin - Weekly Report #2 GSOC 2011 [24/05 - 01/06]
Next
From: Dave Page
Date:
Subject: pgAdmin III commit: Fix slony support for Slony 2.0/PG 9.0.