Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: SQL/JSON: Avoid initializing unnecessary ON ERROR / ON EMPTY ste - Mailing list pgsql-committers

From Amit Langote
Subject Re: pgsql: SQL/JSON: Avoid initializing unnecessary ON ERROR / ON EMPTY ste
Date
Msg-id CA+HiwqFKZiJho_+kYiMOchBc9Zn-mE8Egap_OyQLL=nrKMPDEQ@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: SQL/JSON: Avoid initializing unnecessary ON ERROR / ON EMPTY ste  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tree view 
On Fri, Sep 6, 2024 at 1:19 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Amit Langote <amitlangote09@gmail.com> writes:
> > Yes, thanks for the note.  Will change the test case to test what are
> > deparsing related changes in some other manner.
>
> I usually prefer to test ruleutils.c by deparsing a suitable view.

Yeah, other tests in that file use that method too, so going with
that.  Actually, a few other tests in that file do use VERBOSE, but
with COSTS OFF, so unbitten so far by JIT summary accidentally being
printed out.

--
Thanks, Amit Langote

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: SQL/JSON: Avoid initializing unnecessary ON ERROR / ON EMPTY ste
Next
From: Amit Langote
Date:
Subject: pgsql: SQL/JSON: Fix default ON ERROR behavior for JSON_TABLE