Re: Segmentation fault on proc exit after dshash_find_or_insert - Mailing list pgsql-hackers

From Amit Langote
Subject Re: Segmentation fault on proc exit after dshash_find_or_insert
Date
Msg-id CA+HiwqHSSqUDLrPcBtydSdMuX+KPt7ROhDDLaN_XyeqG8vi99w@mail.gmail.com
Whole thread Raw
In response to Re: Segmentation fault on proc exit after dshash_find_or_insert  (Amit Langote <amitlangote09@gmail.com>)
List pgsql-hackers
Hi Álvaro,

On Wed, Jan 14, 2026 at 10:56 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Wed, Jan 14, 2026 at 6:36 PM Álvaro Herrera <alvherre@kurilemu.de> wrote
> > I would add an Assert(num_held_lwlocks == 0) at the
> > end of LWLockReleaseAll(), to make it clear that it's idempotent (which
> > is important for the case where ProcKill will call it again shortly
> > after).
>
> Makes sense.  Will do.

Done and pushed.  I struggled to write a comment to describe the Assert though.

--
Thanks, Amit Langote



pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: refactor architecture-specific popcount code
Next
From: Japin Li
Date:
Subject: Re: log_min_messages per backend type