Re: patch for issue RM1260 [pgAdmin4] - Mailing list pgadmin-hackers
Ashesh; please review and commit this.
Thanks.
On Wed, Jul 27, 2016 at 3:07 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,Fixed create and delete operations for foreign table.
PFA updated patch for RM1260 (V4).--Harshal DhumalSoftware EngineerOn Wed, Jul 27, 2016 at 6:53 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi Harshal,During testing, I found that create, and delete operation on foreign table is not working.Foreign table node uses, it's own version of Select2 Control, which should have used maximum functionalities from the original NodeAjaxOptionsControl for consistency reason.Hence - I have made the changes.Can you please take a look at the create, and delete operations, and submit combined patch for all those problems?On Wed, Jul 27, 2016 at 3:54 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:and patch file--Harshal DhumalSoftware EngineerOn Wed, Jul 27, 2016 at 3:49 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:2] foreign key: fixed first empty option issue.1] datamodel.js: Added option check against undefined.In addition to RM1260 issue I have added following changes in this patch.Hi,PFA updated patch for RM1260.--Harshal DhumalSoftware EngineerOn Thu, Jul 7, 2016 at 5:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Sure - I will do.On Thu, Jul 7, 2016 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit please?Thanks.--On Thu, Jul 7, 2016 at 7:50 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi,By mistake I deleted a line which was not supposed to be deleted, and that line of code was initialization of select2.--Harshal DhumalSoftware EngineerOn Thu, Jul 7, 2016 at 12:13 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi Harshal,Can you please explain - what was missing in the last patch?On Thu, Jul 7, 2016 at 12:12 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:--Hi,PFA updated patch for issue RM1260--Harshal DhumalSoftware EngineerOn Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi,Please ignore this patch as this has some minor issue. I'll sent updated one.--Harshal DhumalSoftware EngineerOn Wed, Jul 6, 2016 at 5:30 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Changes: Issue wasn't related to foreign table but was due the Select2 control. Now I have improved select2 control to handle null value in multi-select mode. Initial it was returning "null" instead it should return [] (empty array).Hi,PFA patch for issue RM1260.--Harshal DhumalSoftware Engineer
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackersDave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
pgadmin-hackers by date: