Re: Patch to remove Python 2.7 support in the macOS Appbundle - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Patch to remove Python 2.7 support in the macOS Appbundle
Date
Msg-id CA+OCxoxsr+hDf4LhU_=F74QgrRw-_KLoZi_DRubMf0mVuj_aKw@mail.gmail.com
Whole thread Raw
In response to Re: Patch to remove Python 2.7 support in the macOS Appbundle  (Dave Page <dpage@pgadmin.org>)
Responses Re: Patch to remove Python 2.7 support in the macOS Appbundle
List pgadmin-hackers
Akshay, are you happy with this patch?

On Mon, Apr 27, 2020 at 3:30 PM Dave Page <dpage@pgadmin.org> wrote:


On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

The code looks good to me. The package building was tested by Neel and we found that the venv was built with Python 3+ but the runtime was built against Python 2.7.
As per Dave, Neel may have not used a venv of the correct version as it is working fine on Dav'e system. So, we can commit the patch.

Yeah, that's not ideal, but the same problem exists today. I need to spend some time figuring out how to make that more robust. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin][RM5455] Cleanup pgAdmin.py
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Rename the README and fix it up to match modern reali