Re: [pgAdmin4][Patch]: PEP-8 fixes in the foreign data wrapper module - Mailing list pgadmin-hackers

Hi Joao,

On Thu, Mar 1, 2018 at 8:13 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hello Khushboo,

I applied this patch and here is the result:

 2018-03-01 09:41:00 ⌚ |ruby-2.4.1| pgadmin-dev in ~/workspace/pgadmin4/web

± |pep-8-fdw {2} U:13 ✗| → git st

On branch pep-8-fdw

Changes not staged for commit:

  (use "git add <file>..." to update what will be committed)

  (use "git checkout -- <file>..." to discard changes in working directory)

modified:   pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/__init__.py

modified:   pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/__init__.py

modified:   pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/tests/test_foreign_servers_add.py

modified:   pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/tests/test_foreign_servers_delete.py

modified:   pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/tests/test_foreign_servers_get.py

modified:   pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/tests/test_foreign_servers_put.py

modified:   pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/tests/utils.py

modified:   pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/user_mapping/__init__.py

modified:   pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/user_mapping/tests/test_user_mapping_add.py

modified:   pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/user_mapping/tests/test_user_mapping_delete.py

modified:   pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/user_mapping/tests/test_user_mapping_get.py

modified:   pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/user_mapping/tests/test_user_mapping_put.py

modified:   pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/user_mapping/tests/utils.py

no changes added to commit (use "git add" and/or "git commit -a")

 2018-03-01 09:41:03 ⌚ |ruby-2.4.1| pgadmin-dev in ~/workspace/pgadmin4/web

± |pep-8-fdw {2} U:13 ✗| → pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/__init__.py:644: [E123] closing bracket does not match indentation of opening bracket's line

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/__init__.py:651: [E123] closing bracket does not match indentation of opening bracket's line

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/__init__.py:593: [E123] closing bracket does not match indentation of opening bracket's line

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/__init__.py:662: [E123] closing bracket does not match indentation of opening bracket's line

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/__init__.py:669: [E123] closing bracket does not match indentation of opening bracket's line

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/user_mapping/__init__.py:622: [E123] closing bracket does not match indentation of opening bracket's line

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/user_mapping/__init__.py:685: [E123] closing bracket does not match indentation of opening bracket's line

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/user_mapping/__init__.py:692: [E123] closing bracket does not match indentation of opening bracket's line

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/user_mapping/tests/test_user_mapping_add.py:72: [E126] continuation line over-indented for hanging indent

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/user_mapping/tests/test_user_mapping_add.py:84: [E121] continuation line under-indented for hanging indent

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/user_mapping/tests/test_user_mapping_get.py:74: [E126] continuation line over-indented for hanging indent

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/tests/test_foreign_servers_put.py:69: [E126] continuation line over-indented for hanging indent

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/tests/test_foreign_servers_put.py:71: [E121] continuation line under-indented for hanging indent

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/tests/test_fdw_delete.py:25: [E126] continuation line over-indented for hanging indent

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/tests/test_fdw_delete.py:28: [E121] continuation line under-indented for hanging indent

pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/tests/test_fdw_delete.py:55: [E126] continuation line over-indented for hanging indent

3       E121 continuation line under-indented for hanging indent

8       E123 closing bracket does not match indentation of opening bracket's line

5       E126 continuation line over-indented for hanging indent

16

Did I execute the command correctly?

If so there are some things that need to be solved still

Fixed. Patch updated. 

Thanks

Joao

On Thu, Mar 1, 2018 at 8:08 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached patch to fix the PEP-8 issues in the foreign data wrapper module.

Thanks,

Khushboo