Re: CreateEventTrigStmt copy fix - Mailing list pgsql-hackers

From Robert Haas
Subject Re: CreateEventTrigStmt copy fix
Date
Msg-id CA+TgmoYFWV8U00bO3Zhsr2kJZY=jZmYdHVqagDNztz+ogvrqpg@mail.gmail.com
Whole thread Raw
In response to CreateEventTrigStmt copy fix  (Petr Jelinek <petr@2ndquadrant.com>)
List pgsql-hackers
On Fri, Sep 19, 2014 at 12:09 PM, Petr Jelinek <petr@2ndquadrant.com> wrote:
> I was trying to create event trigger inside DO statement inside an extension
> SQL script and noticed that the new event trigger has empty evtevent field.
> After some tinkering with gdb I found out that the memory context switches
> sometimes clear the eventname in CreateEventTrigStmt struct. The reason for
> this is that _copyCreateEventTrigStmt uses COPY_SCALAR_FIELD on eventname
> instead of COPY_STRING_FIELD.
>
> Attached patch fixes this and also the same issue in
> _equalCreateEventTrigStmt.
>
> This should be back-patched to 9.3 where event triggers were introduced.

Done, thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)
Next
From: Josh Berkus
Date:
Subject: Re: jsonb format is pessimal for toast compression