Re: Re: BUG #15039: some question about hash index code - Mailing list pgsql-bugs

From Robert Haas
Subject Re: Re: BUG #15039: some question about hash index code
Date
Msg-id CA+TgmoZHLOP_b+b+E_bWhBP1YsCe7oTDPzfMyTNoOPE7cH_+2g@mail.gmail.com
Whole thread Raw
In response to Re: Re: BUG #15039: some question about hash index code  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Re: BUG #15039: some question about hash index code
Re: Re: BUG #15039: some question about hash index code
List pgsql-bugs
On Thu, Feb 1, 2018 at 1:51 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> Attached patch fix_markbufdirty_hash_index_v1.patch fixes the problem
> by calling MarkBufferDirty at the appropriate place in the code.
> However, I noticed that we might end up calling MarkBufferDirty twice
> for metapage in _hash_addovflpage.  I think we can easily avoid that
> as is done in patch fix_markbufdirty_hash_index_v1.1.patch.

IIUC, the v1 patch is fixing a bug, but the v1.1 patch is a minor
optimization.  I'm going to take the easy way out and push v1 to v10
and master.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-bugs by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: BUG #14952: COPY fails to fill in IDENTITY column default value
Next
From: David Kohn
Date:
Subject: Re: BUG #15036: Un-killable queries Hanging in BgWorkerShutdown