Re: old_snapshot_threshold bottleneck on replica - Mailing list pgsql-hackers

From Robert Haas
Subject Re: old_snapshot_threshold bottleneck on replica
Date
Msg-id CA+TgmoZZt21bLDg9=s9n9e4XE_pu4gxXYWBgKYBpw1wkT9m6yw@mail.gmail.com
Whole thread Raw
In response to Re: old_snapshot_threshold bottleneck on replica  (Maxim Orlov <orlovmg@gmail.com>)
Responses Re: old_snapshot_threshold bottleneck on replica
List pgsql-hackers
On Wed, Jan 25, 2023 at 3:52 AM Maxim Orlov <orlovmg@gmail.com> wrote:
> But in TransactionIdLimitedForOldSnapshots these variable is using conjointly. So, I'm not
> sure, is it completely safe to remove mutex.

Well, that's something we - and ideally you, as the patch author -
need to analyze and figure out. We can't just take a shot and hope for
the best.

> Actually, removing mutex and switch to atomics
> was my first choice. I've run all the tests and no problems were found

Unfortunately, that kind of testing is not very likely to find a
subtle synchronization problem. That's why a theoretical analysis is
so important.

-- 
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: CREATE ROLE bug?
Next
From: Andrew Dunstan
Date:
Subject: More pgindent tweaks