heap_page_prune comments - Mailing list pgsql-hackers

From Robert Haas
Subject heap_page_prune comments
Date
Msg-id CA+TgmoaFjJ57B-RBG-RxE9XMXgXvySns0q8_ujW5CfXM76vgwA@mail.gmail.com
Whole thread Raw
Responses Re: heap_page_prune comments
Re: heap_page_prune comments
List pgsql-hackers
The following comment - or at least the last sentence thereof -
appears to be out of date.
       /*        * XXX Should we update the FSM information of this page ?        *        * There are two schools of
thoughthere. We may not want to update FSM        * information so that the page is not used for unrelated
 
UPDATEs/INSERTs        * and any free space in this page will remain available for further        * UPDATEs in *this*
page,thus improving chances for doing HOT updates.        *        * But for a large table and where a page does not
receive
further UPDATEs        * for a long time, we might waste this space by not updating the FSM        * information. The
relationmay get extended and fragmented further.        *        * One possibility is to leave "fillfactor" worth of
spacein this page        * and update FSM with the remaining space.        *        * In any case, the current FSM
implementationdoesn't accept        * one-page-at-a-time updates, so this is all academic for now.        */
 

The simple fix here is just to delete that last sentence, but does
anyone think we ought to do change the behavior, now that we have the
option to do so?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: DeArchiver process
Next
From: Simon Riggs
Date:
Subject: Re: DeArchiver process