Re: Integer undeflow in fprintf in dsa.c - Mailing list pgsql-hackers

On Tue, Feb 20, 2024 at 5:30 PM Daniel Gustafsson <daniel@yesql.se> wrote:
> The message "at least 0 contiguous pages free" reads a bit nonsensical though,
> wouldn't it be preferrable to check for i being zero and print a custom message
> for that case? Something like the below untested sketch?
>
> +                       if (i == 0)
> +                               fprintf(stderr,
> +                                               "    segment bin %zu (no contiguous free pages):\n", i);
> +                       else
> +                               fprintf(stderr,
> +                                               "    segment bin %zu (at least %d contiguous pages free):\n",
> +                                               i, 1 << (i - 1));

That does seem reasonable. However, this is just debugging code, so it
also probably isn't necessary to sweat anything too much.

--
Robert Haas
EDB: http://www.enterprisedb.com