On Fri, Sep 19, 2025 at 12:36 AM Andres Freund <andres@anarazel.de> wrote:
> I'm planning to commit 0001 soon, unless you'd like to do the honors - I would
> break it with some upcoming patches, and it's a good improvement. Those
> patches also will PinBuffer_Locked() a bit slower, i.e. it'd be good to avoid
> using it in ReadRecentBuffer() for that reason alone.
Oh, thanks for thinking about that interaction. I'll go ahead and
push it later today after I re-convince myself that it's correct.
> > XXX This also fixes ReadRecentBuffer()'s failure to bump the usage
> > count. Fix separately or back-patch this?
>
> FWIW, I'm inclined to not backpatch the usagecount change at this
> point. Unless we have a clear case where it really hurts, I'm more worried
> about disturbing working workloads...
+1
