Re: A question about wording in messages - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: A question about wording in messages
Date
Msg-id CA+hUKGLsEeC-0SnPDJZh9Cbk0vXCCy1ttPD-MXDP=R2kDemGkQ@mail.gmail.com
Whole thread Raw
In response to Re: A question about wording in messages  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: A question about wording in messages
List pgsql-hackers
On Wed, Sep 14, 2022 at 2:38 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> > I saw the following message recently modified.
> >> This controls the maximum distance we can read ahead in the WAL to prefetch referenced data blocks.
> > Maybe the "we" means "PostgreSQL program and you" but I see it
> > somewhat out of place.
>
> +1, I saw that today and thought it was outside our usual style.
> The whole thing is awfully verbose for a GUC description, too.
> Maybe
>
> "Maximum distance to read ahead in WAL to prefetch data blocks."

+1

For "we", I must have been distracted by code comment style.  For the
extra useless verbiage, it's common for GUC description to begin "This
control/affects/blah" like that, but I agree it's useless noise.

For the other cases, Amit's suggestion of 'server' seems sensible to me.



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Kerberos delegation support in libpq and postgres_fdw
Next
From: David Rowley
Date:
Subject: Re: remove_useless_groupby_columns is too enthusiastic