Re: Invisible PROMPT2 - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Invisible PROMPT2
Date
Msg-id CA+hUKGLyfaPyF=-07yQKG3jsMr96HpZYUyAJmaN9SKUay3T8rg@mail.gmail.com
Whole thread Raw
In response to Re: Invisible PROMPT2  (Maxence Ahlouche <maxence.ahlouche@gmail.com>)
List pgsql-hackers
On Mon, Dec 23, 2019 at 5:43 AM Maxence Ahlouche
<maxence.ahlouche@gmail.com> wrote:
> On Wed, 27 Nov 2019 at 17:09, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Good idea, but I think you need to account for "visible" (ie, if the
>> newline is inside RL_PROMPT_START_IGNORE, it shouldn't change the width).
>> It might be best to add logic inside the existing "if (visible)" instead
>> of making a new top-level case.
>
> Right, I assumed that it was safe given that only terminal control characters were invisible.
> Since the title of the terminal window can be changed as well via control characters, it's probably better not to
makethat assumption.
 
>
> I updated the patch accordingly.

Pushed.  Thanks!



pgsql-hackers by date:

Previous
From: "tsunakawa.takay@fujitsu.com"
Date:
Subject: RE: Internal key management system
Next
From: Michael Paquier
Date:
Subject: Re: Add %x to PROMPT1 and PROMPT2