Re: [PATCH] Fix segfault calling PQflush on invalid connection - Mailing list pgsql-bugs

From Daniele Varrazzo
Subject Re: [PATCH] Fix segfault calling PQflush on invalid connection
Date
Msg-id CA+mi_8YiJ_F1L+73tCJCvpxvwhvyHtdhL6KuzMv8OV1DjnRu5g@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Fix segfault calling PQflush on invalid connection  (Francisco Olarte <folarte@peoplecall.com>)
Responses Re: [PATCH] Fix segfault calling PQflush on invalid connection
Re: [PATCH] Fix segfault calling PQflush on invalid connection
List pgsql-bugs
On Mon, 15 Aug 2022 at 13:21, Francisco Olarte <folarte@peoplecall.com> wrote:

> Is there any place in the docs which states libpq just errors out ( as
> opposed to dump core ) on null PGconn? I could not find it easily, and
> I have always assumed the worst ( normally I use it wrapped, use
> nullptr as invalid marked in my data and check that (and either do
> nothing or intentionally SEGV for easier debugging ).

After exercising most of the libpq API in psycopg 3, PQflush() seems
the only one requiring a guard [1]. All the other functions seem to
behave well when passed an "invalid connection" - aka either a NULL
pointer or a connection in BAD status.

[1]
https://github.com/psycopg/psycopg/blob/923bb834ce7601f2743d10bff7e007698429933a/psycopg/psycopg/pq/pq_ctypes.py#L541-L548

-- Daniele


-- Daniele



pgsql-bugs by date:

Previous
From: Sergei Kornilov
Date:
Subject: Re:BUG #17568: unexpected zero page at block 0 during REINDEX CONCURRENTLY
Next
From: Alvaro Herrera
Date:
Subject: Re: Regression in pipeline mode in libpq 14.5