Re: Protect syscache from bloating with negative cache entries - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: Protect syscache from bloating with negative cache entries
Date
Msg-id CA+q6zcXw9jUJCwPBqo=NAELj_TporkBPAuGdqV3hDbrzRGEeTA@mail.gmail.com
Whole thread Raw
In response to Re: Protect syscache from bloating with negative cache entries  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
List pgsql-hackers
> On Tue, Nov 27, 2018 at 11:40 AM Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
>
> The attached is the rebased version that has multidimentional
> ageclass.

Thank you,

Just for the information, cfbot complains about this patch because:

pgstatfuncs.c: In function ‘pgstat_get_syscache_stats’:
pgstatfuncs.c:1973:8: error: ignoring return value of ‘fread’,
declared with attribute warn_unused_result [-Werror=unused-result]
   fread(&cacheid, sizeof(int), 1, fpin);
        ^
pgstatfuncs.c:1974:8: error: ignoring return value of ‘fread’,
declared with attribute warn_unused_result [-Werror=unused-result]
   fread(&last_update, sizeof(TimestampTz), 1, fpin);
        ^

I'm moving it to the next CF as "Waiting on author", since as far as I
understood you want to address more commentaries from the reviewer.


pgsql-hackers by date:

Previous
From: Dmitry Dolgov
Date:
Subject: Re: Refactoring the checkpointer's fsync request queue
Next
From: Dmitry Dolgov
Date:
Subject: Re: jsonpath