> Now with the `ISO C90 forbids mixed declarations and code` warning cleared up. > > Weird that there’s a failure on Bookworm with Meson [1] (pg_regress diffs [2]) but not Bookworm with Configure [3]. Collation issue, perhaps?
David Johnson noticed that this build is 32-bit. I looked at the split_path function and after trying a couple of things, realized that it was passing an int8 when the SQL function in Marlena.c passes an int4. This change got the test passing in my clone (indentation reduced):
Occasionally I've noticed myself some inconsistencies wrt to compiler warnings between meson & make .
- I like your changes and renames on the parser/lexer; it indeed looks much cleaner now and will help with future improvements.
- I also like the addition of executeStringInternalMethod ; it'll help us add more stuff in the future (reminder that for the original patch I implemented the methods I'd like more, but string operations are quite more).
- AFAICT no test cases / results have changed with your versions; is this correct ?
