Re: [PATCH] add relation and block-level filtering to pg_waldump - Mailing list pgsql-hackers

From David Christensen
Subject Re: [PATCH] add relation and block-level filtering to pg_waldump
Date
Msg-id CA702020-B3F9-4597-86F7-EFB1CB7D6E42@crunchydata.com
Whole thread Raw
In response to Re: [PATCH] add relation and block-level filtering to pg_waldump  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: [PATCH] add relation and block-level filtering to pg_waldump
List pgsql-hackers
> On Mar 24, 2022, at 6:43 AM, Thomas Munro <thomas.munro@gmail.com> wrote:
>
> On Fri, Mar 25, 2022 at 12:26 AM Thomas Munro <thomas.munro@gmail.com> wrote:
>>> On Fri, Mar 25, 2022 at 12:01 AM Peter Eisentraut
>>> <peter.eisentraut@enterprisedb.com> wrote:
>>> Or even:  Why are we exposing fork *numbers* in the user interface?
>>> Even low-level tools such as pageinspect use fork *names* in their
>>> interface.
>>
>> I wondered about that but thought it seemed OK for such a low level
>> tool.  It's a fair point though, especially if other low level tools
>> are doing that.  Here's a patch to change it.
>
> Oh, and there's already a name lookup function to use for this.

+1 on the semantic names.

David


pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Documenting when to retry on serialization failure
Next
From: Daniel Gustafsson
Date:
Subject: Re: TAP output format in pg_regress