Re: [FEATURE] Add schema option to all relevant objects - Mailing list pgadmin-hackers

On 9 July 2011 12:56, Guillaume Lelarge <guillaume@lelarge.info> wrote:
> On Sat, 2011-07-09 at 10:33 +0100, Thom Brown wrote:
>> On 9 July 2011 09:28, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>> > On Sat, 2011-07-09 at 00:23 +0100, Thom Brown wrote:
>> >> On 9 July 2011 00:12, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>> >> > On Fri, 2011-07-08 at 21:55 +0200, Guillaume Lelarge wrote:
>> >> >> On Fri, 2011-07-08 at 20:06 +0100, Thom Brown wrote:
>> >> >> > On 8 July 2011 19:46, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>> >> >> > > On Thu, 2011-07-07 at 23:24 +0100, Thom Brown wrote:
>> >> >> > >> On 7 July 2011 23:20, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>> >> >> > >> > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote:
>> >> >> > [...]
>> >> >> > > And that should be all. The fixed patch is attached. There is one
>> >> >> > > remaining issue: how to refresh the object's parent node in the new
>> >> >> > > schema?
>> >> >> >
>> >> >> > I played around with rebuilding the node path with the new schema name
>> >> >> > to refresh it, but I kept getting endless data type issues, and have
>> >> >> > no idea how this node stuff works, so I'm not sure what to do about
>> >> >> > that.  Have any guidance?  If not, I might have another attempt at
>> >> >> > working out how to manipulate nodes.
>> >> >> >
>> >> >>
>> >> >> I'll try to look into this, but I don't think I'll be lucky.
>> >> >>
>> >> >
>> >> > I was wrong. I have it working. Code is ugly right now, so it'll need
>> >> > some cleanup/refactoring/etc. Should be able to commit it tomorrow :)
>> >>
>> >> Excellent.  I'll be interested to see what you needed to do to achieve
>> >> it.  Merci beaucoup.
>> >>
>> >
>> > Not much actually. See refresh.patch. ShowObject() in dlgProperty is
>> > responsible of displaying objects in the treeview. I just added the code
>> > that goes back to the Schemas node, and made it resfresh it.
>> >
>> > add_schemas_v3.patch is the final patch. I'm intending to apply it
>> > rather soon.
>>
>> Oh I see.  I thought the objective was to refresh the old direct
>> parent node of the old object's location to make it disappear, then
>> refresh the new parent node of the object's new location to make it
>> reappear, then to set the focus on the new object.  Your way
>> simplifies it and works for me. :)
>>
>
> I would prefer to only refresh the old parent node, and the new parent
> node. But we have no way to know the new parent node. So I refresh all
> schemas. Which will bring other performance issues for users with big
> schemas.
>
>> I'll try building it again and testing it with the new changes,
>> although because it's only on my little netbook and I want to do a
>> clean build, that could take some time, so you may have already
>> committed this by the time I get to test it.  But I'll let you know if
>> there's any problem.
>>
>
> I don't expect to commit this before tomorrow. So I sincerely hope your
> build will be finished by then :)

Okay, tested it, and yes, it refreshes fine.  It would be nice if, at
a future point, we could use a targetted refresh and refocus on the
new item, but I'd say that's a nice-to-have.

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company