Re: Optimize SnapBuildPurgeOlderTxn: use in-place compaction instead of temporary array - Mailing list pgsql-hackers

From Neil Chen
Subject Re: Optimize SnapBuildPurgeOlderTxn: use in-place compaction instead of temporary array
Date
Msg-id CAA3qoJn_VEBjkjw9+2yx+8Qgr41WhoTZ5sdKxZ9B9H6bBLKORA@mail.gmail.com
Whole thread Raw
In response to Re: Optimize SnapBuildPurgeOlderTxn: use in-place compaction instead of temporary array  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
Hi Xuneng Zhou, Masahiko,

On Thu, Jan 15, 2026 at 6:01 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
On Thu, Jan 8, 2026 at 7:57 PM Xuneng Zhou <xunengzhou@gmail.com> wrote:
>
> I think improving test coverage is generally beneficial and also helps
> build familiarity with the codebase.

Yes. For instance, the commit 00c3d87a5ca added the test module for
Bitmapset, increasing the test coverage from 85.2% to 93.4%, which is
very nice. While adding more tests is basically beneficial, we need to
keep in mind that test execution time is also important. It would be
great if new tests increase the test coverage and don't take a long
time to complete.


Thank you so much for your valuable suggestions!

I totally agree that balancing test coverage and execution performance is crucial. 
I will prioritize selecting the core processes for the tests and make sure to keep 
the overall execution time in check while improving coverage.

pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: CREATE TABLE LIKE INCLUDING TRIGGERS
Next
From: Neil Chen
Date:
Subject: Re: nbtree: reduce code redundancy by using _bt_getmeta() in _bt_gettrueroot()