Postgres Pro
Downloads
Home   >   mailing lists

Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid
Date
Msg-id CAA4eK1JEotM3K9JrDwhNJmfEuOW9bpV5Eh+TTneaOQiLJYfW6w@mail.gmail.com
Whole thread Raw
List pgsql-hackers
Tree view 
On Fri, Nov 8, 2024 at 3:17 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> It appears that we are passing InvalidOid instead of InvalidRelFileNumber when calling index_create(). While this
isn’ttechnically a bug, since InvalidRelFileNumber is defined as InvalidOid, it’s preferable to use the correct
identifierfor clarity and consistency. 
>

Agreed. We already use InvalidRelFileNumber at one of the other
callers in index_concurrently_create_copy(). Your patch looks good to
me.

--
With Regards,
Amit Kapila.

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: define pg_structiszero(addr, s, r)
Next
From: Alvaro Herrera
Date:
Subject: Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid