Re: Conflict detection for update_deleted in logical replication - Mailing list pgsql-hackers

On Tue, Sep 16, 2025 at 11:13 AM shveta malik <shveta.malik@gmail.com> wrote:
>
> >
> > I updated the patch to fix this as well.
> >
>
> Thank You for the patch. Fix looks good.
>
> Shall we update the comment:
> +# Drop the physical slot and reset the synchronized_standby_slots setting. We
> +# change this after setting max_retention_duration to 0, ensuring the apply
> +# worker does not resume prematurely without noticing the updated
> +# max_retention_duration value.
>
> to:
> Drop the physical slot and reset the synchronized_standby_slots
> setting. This adjustment is made after setting max_retention_duration
> to 0, ensuring consistent results in the test case as the resumption
> becomes possible immediately after resetting
> synchronized_standby_slots, due to the smaller max_retention_duration
> value of 1ms previously.
>

Thanks, I have modified the patch based on what you suggested and pushed.

--
With Regards,
Amit Kapila.