Re: New GUC autovacuum_max_threshold ? - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: New GUC autovacuum_max_threshold ?
Date
Msg-id CAA5RZ0tAqjtJz+2=S1LvDUJfrpGa73nmLccwvr_R1r8CC4HmaA@mail.gmail.com
Whole thread Raw
In response to Re: New GUC autovacuum_max_threshold ?  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
> Here is a rebased version of the patch (commit ca9c6a5 adjusted the
> documentation for vacuum-related GUCs).

I looked at the patch and have a few comments.

I propose renaming the GUC from "autovacuum_max_threshold" to
"autovacuum_vacuum_max_threshold" to clarify that it applies only
to the vacuum operation performed by autovacuum, not to the analyze operation.
This will also align with naming for other related GUCs, i.e.,
"autovacuum_analyze_threshold" and "autovacuum_vacuum_threshold."

The "vacuum threshold" calculation described in [1] will also need to be
updated.

[1] https://www.postgresql.org/docs/current/routine-vacuuming.html#AUTOVACUUM

Regards,

Sami



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgbench error: (setshell) of script 0; execution of meta-command failed
Next
From: Michail Nikolaev
Date:
Subject: Re: Issue with markers in isolation tester? Or not?