Re: question about pending updates in pgstat_report_inj - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: question about pending updates in pgstat_report_inj
Date
Msg-id CAA5RZ0u+5Rh7tMWOQv=krPKyQ=SFoOk44q68W5knK-d=qE2Rhg@mail.gmail.com
Whole thread Raw
In response to Re: question about pending updates in pgstat_report_inj  (Michael Paquier <michael@paquier.xyz>)
Responses Re: question about pending updates in pgstat_report_inj
List pgsql-hackers
> On Mon, Sep 15, 2025 at 05:33:45PM -0500, Sami Imseih wrote:
> > I think it's better to use ->pending here, since this is referenced
> > as an example and most real-world cases will likely want to use
> > ->pending for performance reasons.
>
> Yes, it should use the pending entry.  b757abefc041 did not get that
> completely right.
>
> The purpose of this code is also to serve as a template, so better
> that it does the correct thing.
>
> How about renaming "statent" to "pending" in pgstat_report_inj(), as
> well?  That would be a bit more consistent with the subscription stat
> case, at least.

0001 LGTM.

--
Sami



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: OAuth client code doesn't work with Google OAuth
Next
From: Nathan Bossart
Date:
Subject: Re: GetNamedLWLockTranche crashes on Windows in normal backend