Re: Improve LWLock tranche name visibility across backends - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: Improve LWLock tranche name visibility across backends
Date
Msg-id CAA5RZ0uh_WviMnh9z-oZP32SSE5MBEshzx5Cfe0rFYnPwQNzJw@mail.gmail.com
Whole thread Raw
In response to Re: Improve LWLock tranche name visibility across backends  (Rahila Syed <rahilasyed90@gmail.com>)
List pgsql-hackers
Thanks for testing!

> Why is it necessary to allocate a new dsa_pointer for tranche names that are the same size and then
> free the old one?
> Is there a reason we can't just assign new_ptrs[i] = old_ptrs[i]?

Fair point. I will updated in the next rev. We don't need to free the'
existing tranche name pointers, only the list.

> Would it be possible to update LWLockInitialize so that it checks if tranche_id is
> already registered in the dsa, and if not, registers it during the LWLockInitialize() process?

We could. I do think this will need a separate discussion as a follow-up to this
thread.

--
Sami



pgsql-hackers by date:

Previous
From: Sami Imseih
Date:
Subject: Re: Improve LWLock tranche name visibility across backends
Next
From: Nathan Bossart
Date:
Subject: Re: fix ancient typo in transformRelOptions()