Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master - Mailing list pgsql-hackers

From David Rowley
Subject Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master
Date
Msg-id CAApHDvo4bmZtT9Ta1t68JFEmMvLYw1rLx0+4xZxfBvBm=jZCSQ@mail.gmail.com
Whole thread Raw
In response to Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master  (邱宇航 <iamqyh@gmail.com>)
Responses Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master
Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master
List pgsql-hackers
On Tue, 23 Sept 2025 at 15:49, 邱宇航 <iamqyh@gmail.com> wrote:
> I've noticed that two GROUP BY ROLLUP queries behave differently in v17
> compared to master and REL_18_STABLE. The issue can be reproduced by
> following SQL:
>
> After some git bisect work, I traced the root cause:
> - The first issue was introduced by commit f5050f79 (Mark expressions
> nullable by grouping sets).
> - The second issue stems from commit 67a54b9e (Allow pushdown of HAVING
> clauses with grouping sets).

If you check the release notes and the commit message for f5050f795
you'll see that it does mention that wrong results could be returned.

What wasn't mentioned was that this wasn't fixed in prior versions.
The reason being is that the fix required changing the query tree
representation, which we can't change in the back branches due to
incompatibility with stored rules in existing databases. So, a change
in query results for certain queries here is expected.

David



pgsql-hackers by date:

Previous
From: Shlok Kyal
Date:
Subject: Re: issue with synchronized_standby_slots
Next
From: Vaibhav Jain
Date:
Subject: Re: Fix overflow of nbatch