Re: Fix wrong filename in header comment of gin_tuple.h - Mailing list pgsql-hackers

From David Rowley
Subject Re: Fix wrong filename in header comment of gin_tuple.h
Date
Msg-id CAApHDvpCOoOA-gkLUbtz9zgDFpGS7+qMAr3W-xXE2uzq6m03=A@mail.gmail.com
Whole thread Raw
In response to Re: Fix wrong filename in header comment of gin_tuple.h  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: Fix wrong filename in header comment of gin_tuple.h
List pgsql-hackers
On Mon, 22 Sept 2025 at 14:46, Chao Li <li.evan.chao@gmail.com> wrote:
> diff --git a/src/backend/rewrite/rowsecurity.c b/src/backend/rewrite/rowsecurity.c

> - * rewrite/rowsecurity.c
> + * rowsecurity.c

> + *
> + * IDENTIFICATION
> + *    src/backend/rewrite/rowsecurity.c

I don't what's incorrect with these as I'm not aware of the rule that
the IDENTIFICATION must exist or that the filename must be the
filename only without any of the path. Plenty of other files don't
have the identification text, so not sure why your script only picked
up on rowsecurity.c.

It maybe would make more sense if you posted the script, or
highlighted why rowsecurity.c is special out of all the files that
don't contain an "IDENTIFICATION".

Also, I'm not interested in making any large churn here for stylistic
reasons. I think that would end up as a huge patch for no measurable
gains.

David



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: RFC: extensible planner state
Next
From: Nathan Bossart
Date:
Subject: Re: [PATCH] Hex-coding optimizations using SVE on ARM.