Re: Refactor StringInfo usage in subscriptioncmds.c - Mailing list pgsql-hackers

From David Rowley
Subject Re: Refactor StringInfo usage in subscriptioncmds.c
Date
Msg-id CAApHDvpiprh4Geb+T=96OCNG31PSgrp7cCihy9R0ovOfttxkjw@mail.gmail.com
Whole thread Raw
In response to Refactor StringInfo usage in subscriptioncmds.c  (Mats Kindahl <mats.kindahl@gmail.com>)
Responses Re: Refactor StringInfo usage in subscriptioncmds.c
List pgsql-hackers
On Fri, 7 Nov 2025 at 00:38, Mats Kindahl <mats.kindahl@gmail.com> wrote:
> As discussed in [1] the functions check_publications_origin_tables() and
> check_publications_origin_sequences() are building error messages using
> dynamically allocated StringInfo instances only to avoid duplicating a
> call of ereport().

Looks better and more traditional to me, plus git diff --stat reports:

1 file changed, 28 insertions(+), 33 deletions(-)

It has my vote. I've included Vignesh and Amit to see if they're also
ok with it.

David



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Some efforts to get rid of "long" in our codebase
Next
From: Heikki Linnakangas
Date:
Subject: Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue