Re: [PATCH] Add tests for Bitmapset - Mailing list pgsql-hackers

From David Rowley
Subject Re: [PATCH] Add tests for Bitmapset
Date
Msg-id CAApHDvpn3bshX+_2t0NbJ263r1etcBdmkROjuJw8DvyZkMcXqg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add tests for Bitmapset  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] Add tests for Bitmapset
List pgsql-hackers
On Thu, 9 Oct 2025 at 15:13, Michael Paquier <michael@paquier.xyz> wrote:
> What do you think about the attached?

Thanks. Looks pretty good.

> + members = palloc(sizeof(int) * num_ops);

Any reason to pfree that and allocate that to the same size as it already was?

Wondering if the "members[pos] = members[--num_members];" is worth a
short comment. Maybe something like: /* zap this member by moving the
final array member into its place and shrinking the array by 1 */

David



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PROPOSAL] Termination of Background Workers for ALTER/DROP DATABASE
Next
From: Chao Li
Date:
Subject: Re: Enhance Makefiles to rebuild objects on map file changes