Request a Demo
Home   >   mailing lists

Re: Refactor StringInfo usage in subscriptioncmds.c - Mailing list pgsql-hackers

From David Rowley
Subject Re: Refactor StringInfo usage in subscriptioncmds.c
Date
Msg-id CAApHDvpqtYQeq7YkH9V-PNBJU-caBA4Arf8_zCmYuU1BQk8B3g@mail.gmail.com
Whole thread Raw
In response to Re: Refactor StringInfo usage in subscriptioncmds.c  (Mats Kindahl <mats.kindahl@gmail.com>)
List pgsql-hackers
Tree view 
On Fri, 7 Nov 2025 at 01:47, Mats Kindahl <mats.kindahl@gmail.com> wrote:
> > I agree with Amit that there doesn't seem to be a need to free
> > pubnames.data.  We're already leaking publist, for instance.  This is
> > okay since we only call these functions during DDL, which in general is
> > not sensitive to leaks.
>
> Seems reasonable. Here is an updated version that removes the pfree() calls.

Sounds like all are in favour. Pushed.

David

pgsql-hackers by date:

Previous
From: Philip Alger
Date:
Subject: Re: [PATCH] Add pretty formatting to pg_get_triggerdef
Next
From: Jeff Davis
Date:
Subject: Re: Built-in case-insensitive collation pg_unicode_ci