Re: [PATCH] Add tests for Bitmapset - Mailing list pgsql-hackers

From David Rowley
Subject Re: [PATCH] Add tests for Bitmapset
Date
Msg-id CAApHDvqXdBWMwGuzJBSbq4eiNLDaR738-upd8NJpmhUq3a+XLQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add tests for Bitmapset  (Greg Burd <greg@burd.me>)
Responses Re: [PATCH] Add tests for Bitmapset
List pgsql-hackers
On Thu, 9 Oct 2025 at 07:48, Greg Burd <greg@burd.me> wrote:
>                      bms = bms_del_member(bms, member);
> +                    num_members--;
> +                    memmove(members + pos, members + pos + 1,
> +                                     (num_members - pos) * sizeof(int));

I don't think there's any need to maintain the order of that members
array, so couldn't you just do this?:

bms = bms_del_member(bms, member);
members[pos] = members[--num_members];

David



pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Eager aggregation, take 3
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: [PROPOSAL] Termination of Background Workers for ALTER/DROP DATABASE