Postgres Pro
Downloads
Home   >   mailing lists

Re: PATCH: numeric timestamp in log_line_prefix - Mailing list pgsql-hackers

From David Rowley
Subject Re: PATCH: numeric timestamp in log_line_prefix
Date
Msg-id CAApHDvraosOWocYwZLdBZKCJz_6TGpF9tibL3RrH8raxHNUHhw@mail.gmail.com
Whole thread Raw
In response to PATCH: numeric timestamp in log_line_prefix  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: PATCH: numeric timestamp in log_line_prefix
List pgsql-hackers
Tree view
On 22 March 2015 at 12:47, Tomas Vondra <tomas.vondra@2ndquadrant.com> wrote:

I propose adding two new log_line_prefix escape sequences - %T and %M,
doing the same thing as %t and %m, but formatting the value as a number.


Hi Tomas,

I just had a quick glance at this.
Is there a reason you didn't include code to support the space padding for the new log_line_prefixes?
The others support  %<padding><char> in the prefix, to allow left or right alignment of the item.

Also, what's the reason for timestamp_str? Could you not just use appendStringInfo() and skip the temporary buffer?

Regards

David Rowley 

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Performance improvement for joins where outer side is unique
Next
From: Pavel Stehule
Date:
Subject: Re: [PATCH] Add transforms feature