Re: Incorrect XLogRegisterBuffer flag for revmapbuf in brin - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Incorrect XLogRegisterBuffer flag for revmapbuf in brin
Date
Msg-id CAB7nPqQ91+Uj2wR8UQNWe-2gEAp=naM_HsM2P1ir26LWBhe2mA@mail.gmail.com
Whole thread Raw
In response to Incorrect XLogRegisterBuffer flag for revmapbuf in brin  (Kuntal Ghosh <kuntalghosh.2007@gmail.com>)
Responses Re: [HACKERS] Incorrect XLogRegisterBuffer flag for revmapbuf in brin
List pgsql-hackers
On Wed, Nov 9, 2016 at 9:33 PM, Kuntal Ghosh <kuntalghosh.2007@gmail.com> wrote:
> In brin_doupdate(line 290), REGBUF_STANDARD is used to register
> revmap buffer reference in WAL record. But, revmap buffer page doesn't
> have a standard page layout and it doesn't update pd_upper and
> pd_lower as well.
>
> Either we should register revmapbuf as following:
> XLogRegisterBuffer(1, revmapbuf, 0);

As this is not a standard buffer, let's do it this way. This issue has
been captured by the WAL consistency patch.
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: WAL consistency check facility
Next
From: "Tsunakawa, Takayuki"
Date:
Subject: Re: [bug fix] Cascading standby cannot catch up and get stuck emitting the same message repeatedly