Re: pg_xlogdump MSVC build script oddities - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_xlogdump MSVC build script oddities
Date
Msg-id CAB7nPqRM-H3wfF3YHnYsUPrOHrM7MoG2MZO9uKx73B+otxQ6OA@mail.gmail.com
Whole thread Raw
In response to pg_xlogdump MSVC build script oddities  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
On Thu, Mar 19, 2015 at 11:25 AM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> I'm guessing that the current state of affairs is just an oversight. I tried
> changing it so that xlogreader.c is built into pg_xlogdump without copying,
> and it seemed to work. But I'm using a very recent version of MSVC - perhaps
> it won't work on pre-VS2011 versions.
>
> Unless someone has some insights on this, I'm going to commit the attached,
> and see what the buildfarm thinks of it.

This looks good to me. I just tested your patch on MS 2010, and it
worked, but that's perhaps not old enough to trigger the problem. Now
currawong and mastodon would be the real tests..
Regards,
-- 
Michael



pgsql-hackers by date:

Previous
From: Max Filippov
Date:
Subject: configure can't detect proper pthread flags
Next
From: Bruce Momjian
Date:
Subject: Re: proposal: doc: simplify examples of dynamic SQL