Re: pg_rewind just doesn't fsync *anything*? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_rewind just doesn't fsync *anything*?
Date
Msg-id CAB7nPqTqqCHKkFNJc77B_4VcXWJGO8OFgxN+PMa+5pv=eCkMMw@mail.gmail.com
Whole thread Raw
In response to Re: pg_rewind just doesn't fsync *anything*?  (Andres Freund <andres@anarazel.de>)
Responses Re: pg_rewind just doesn't fsync *anything*?
List pgsql-hackers
On Thu, Mar 10, 2016 at 7:52 PM, Andres Freund <andres@anarazel.de> wrote:
>> a target data folder should be stopped properly to be able to rewind,
>> and it is better to avoid dependencies between utilities if that's not
>> strictly necessary.  initdb is likely to be installed side-by-side
>> with pg_rewind in any distribution though.
>
> It's not like we don't have any other such dependencies, in other
> binaries. I'm not concerned.
>
> Having to backpatch a single system() invocation + find_other_exec()
> call, and backporting a more general FRONTEND version of initdb's
> fsync_pgdata() are wildly differing in complexity.

Talking about HEAD, wouldn't the dependency tree be cleaner if there
is a common facility in src/common? For back-branches, I won't argue
against simplicity, those are more reliable solutions.
-- 
Michael



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Freeze avoidance of very large table.
Next
From: Peter Geoghegan
Date:
Subject: Re: Using quicksort for every external sort run