Re: [HACKERS] Reporting query on crash even if completed - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [HACKERS] Reporting query on crash even if completed
Date
Msg-id CABUevEwR_-tCmbs+ky=oxCSnAcBkc3u0QJ_e3t9SO1FmYLce=A@mail.gmail.com
Whole thread
In response to Re: [HACKERS] Reporting query on crash even if completed  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Mon, Sep 18, 2017 at 6:12 PM, Robert Haas <robertmhaas@gmail.com> wrote:
On Mon, Sep 18, 2017 at 9:47 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Now, for pg_stat_activity part of the argument why this wouldn't be
> confusing was that you could also see the "state" field.  Maybe we
> should try to shoehorn equivalent info into the crash log entry?

Yeah, I think so.  Really, I think this is an inadvertency, and thus a

Yeah, I agree. That was nothing I recall thinking about at the time, so strictly speaking it's a bug.

 
bug.  But instead of just not showing the query when the backend is
idle, I'd change the display for that case to:

DETAIL: Failed process was idle; last query was: %s

Or something like that.  I guess we'd need another case for a backend
that crashed without ever running a query.

+1, this is a better solution. 

--

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Reporting query on crash even if completed
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Boom filters for hash joins (was: A design for amcheck heapam verification)