Re: [PATCH] Fix "push changes" crash in CommunityAuthSiteAdminForm - Mailing list pgsql-www

From Magnus Hagander
Subject Re: [PATCH] Fix "push changes" crash in CommunityAuthSiteAdminForm
Date
Msg-id CABUevEx1Ye8jWYkuOqaao+aPX4oGAsuk4thFJx_Hd4LxoP1PyQ@mail.gmail.com
Whole thread Raw
In response to [PATCH] Fix "push changes" crash in CommunityAuthSiteAdminForm  (Célestin Matte <celestin.matte@cmatte.me>)
Responses Re: [PATCH] Fix "push changes" crash in CommunityAuthSiteAdminForm
List pgsql-www
On Thu, Sep 9, 2021 at 12:09 PM Célestin Matte <celestin.matte@cmatte.me> wrote:
>
> Hello,
>
> I'm in the process of writing an Ansible script to install pglister, and for this, I'm using pgweb's auth system.
> I've encountered a crash in the web form to add a community auth site on the "push changes" option (on pgweb). This
patchfixes it. 

Hi!

Thanks! the fix looks good in general -- but how did you actually hit
the bug? I've been trying to reproduce it to verify the test, but I
can't figure out how... In all my tests, d['apiurl'] ends up being ''
(and actually existing), which makes it not a problem.


--
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/



pgsql-www by date:

Previous
From: Célestin Matte
Date:
Subject: [PATCH] Fix "push changes" crash in CommunityAuthSiteAdminForm
Next
From: Célestin Matte
Date:
Subject: Re: [PATCH] Fix "push changes" crash in CommunityAuthSiteAdminForm