Re: [HACKERS] pg_basebackups and slots - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [HACKERS] pg_basebackups and slots
Date
Msg-id CABUevEx2Vhmy3sP9fj6byU5eiBx7oq90xDwo2qrH7wS7ZVv+UA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] pg_basebackups and slots  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] pg_basebackups and slots
List pgsql-hackers


On Fri, Dec 16, 2016 at 7:40 AM, Michael Paquier <michael.paquier@gmail.com> wrote:
On Fri, Dec 16, 2016 at 3:32 PM, Magnus Hagander <magnus@hagander.net> wrote:
> I don't really know how to write a good test for it. I mean, we could run it
> with the parameter, but how to we make it actually verify the slot? Make a
> really big database to make it guaranteed to be slow enough that we can
> notice it in a different session?

No, not that. I was meaning tests to trigger the error code paths with
the compatibility switches you are adding.

There is only one switch - --no-slot. I guess you mean rune one backup with that one? Sure, that's easy enough to do. I'm not sure how much it really tests, but let's do it :)

You mean something like this, right?

--
Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] pg_basebackups and slots
Next
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] pg_basebackups and slots