Re: [PATCH] Verify Checksums during Basebackups - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCH] Verify Checksums during Basebackups
Date
Msg-id CABUevEzTxq+Cm8YNZVkzm+25cs6v9U60ad8r=T6vkFzzQym76Q@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Verify Checksums during Basebackups  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


On Tue, Apr 3, 2018 at 4:32 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
I wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Unless.. %ld is the wrong thing to print:
>> static int64 total_checksum_failures;
>> We should perhaps be using something other than %ld to print that?

> INT64_FORMAT.

BTW, don't just stick INT64_FORMAT into the message-to-be-translated,
or you'll break things for translation.  Good practice is to sprintf
into a local char array with INT64_FORMAT, then include the number
into the displayed message with %s.  You can find examples easily
by grepping for INT64_FORMAT.

Thanks for the hint. I've pushed a fix along this line, let's see if clears things. 


--

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: jsonb nesting level edge case
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] logical decoding of two-phase transactions