On 3/3/16 12:16 AM, Haribabu Kommi wrote: > On Fri, Feb 5, 2016 at 2:29 PM, Haribabu Kommi <kommi.haribabu@gmail.com> wrote: >> >> This patch needs to be applied on top discard_hba_and_ident_cxt patch >> that is posted earlier. > > Here I attached a re-based patch to the latest head with inclusion of > discard_hba_ident_cxt patch for easier review as a single patch.
Alex, Scott, do you have an idea of when you'll be able to review this new version?
The new version applies with some fuzziness to the current master and compiles cleanly.
Some comments:
+/* Context to use with hba_line_callback function. */
+typedef struct
+{
+ MemoryContext memcxt;
+ TupleDesc tupdesc;
+ Tuplestorestate *tuple_store;
+} HbalineContext;
Rather "with *lookup_hba_line_callback*", as hba_line_callback() is a generic one.
Hm... now I'm not sure if we really need the "mode" column. It should be clear that we skipped every line that had a non-NULL "reason". I guess we could remove "mode" and rename "reason" to "skip_reason"?
Still remains an issue of representing special keywords in database and user_name fields, but there was no consensus about that though.
