pg_dumpall appendPQExpBuffer construct sql need an white space - Mailing list pgsql-hackers

From jian he
Subject pg_dumpall appendPQExpBuffer construct sql need an white space
Date
Msg-id CACJufxGkvhD_S9hGium08MCVqKqpreyq01NzDqajqYJ=R+xg2Q@mail.gmail.com
Whole thread Raw
Responses Re: pg_dumpall appendPQExpBuffer construct sql need an white space
List pgsql-hackers
hi.

in src/bin/pg_dump/pg_dumpall.c
    appendPQExpBuffer(buf, " FROM pg_auth_members a "
                      "LEFT JOIN %s ur on ur.oid = a.roleid "
                      "LEFT JOIN %s um on um.oid = a.member "
                      "LEFT JOIN %s ug on ug.oid = a.grantor "
                      "WHERE NOT (ur.rolname ~ '^pg_' AND um.rolname ~ '^pg_')"
                      "ORDER BY 1,2,4", role_catalog, role_catalog,
role_catalog);

here "WHERE NOT (ur.rolname ~ '^pg_' AND um.rolname ~ '^pg_')"
need a white space at the end?



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Issue with markers in isolation tester? Or not?
Next
From: Tom Lane
Date:
Subject: Re: pg_dumpall appendPQExpBuffer construct sql need an white space