Postgres Pro
Downloads
Home   >   mailing lists

Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
Date
Msg-id CAD21AoAa4vTH0Up1QUdbpnROnrC3+iGe_LS4sG6XKwZT-o-Kpw@mail.gmail.com
Whole thread Raw
In response to Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c  (Japin Li <japinli@hotmail.com>)
Responses Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c
List pgsql-hackers
Tree view 
On Wed, Jun 14, 2023 at 12:33 PM Japin Li <japinli@hotmail.com> wrote:
>
>
> Hi, hackers
>
> We use (GUC_UNIT_MEMORY | GUC_UNIT_TIME) instead of GUC_UNIT even though we
> already define it in guc.h.
>
> Maybe using GUC_UNIT is better?  Here is a patch to fix it.

Yeah, it seems more consistent with other places in guc.c. I'll push
it, barring any objections.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Fix a typo in md.c
Next
From: Masahiko Sawada
Date:
Subject: Re: make_ctags: use -I option to ignore pg_node_attr macro