Re: POC: enable logical decoding when wal_level = 'replica' without a server restart - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: POC: enable logical decoding when wal_level = 'replica' without a server restart
Date
Msg-id CAD21AoCanNCGuLLwz7fcY4uMO3Kwhw2UrvAibn_UzB1U=hiS+Q@mail.gmail.com
Whole thread Raw
In response to RE: POC: enable logical decoding when wal_level = 'replica' without a server restart  ("Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>)
List pgsql-hackers
On Wed, Dec 24, 2025 at 12:42 AM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
> Hi,
>
> I noticed a BF failure [1] related to this commit.
>
> Commit 67c209 removes the WARNING for insufficient wal_level from the output,
> but the WARNING may still appear on BF animals that default to
> wal_level=minimal.
>
> To avoid tests that produce varying messages based on wal_level, we could modify
> the test to use ALTER PUBLICATION for verifying the same NOTICE. Attached is a
> small patch addressing this issue.
>
> We could also simply remove these tests but that seems to reduce the test
> coverage a bit.

Thank you for reporting this issue and creating the patch!

The change looks good to me, and I've confirmed that regression tests
with the same configuration as thorntail pass with the proposed patch.
So I've pushed the patch.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: should we have a fast-path planning for OLTP starjoins?
Next
From: Bruce Momjian
Date:
Subject: Re: DOCS - Clarify the publication 'publish_via_partition_root' default value.