Postgres Pro
Downloads
Home   >   mailing lists

Re: Request for comment on setting binary format output per session - Mailing list pgsql-hackers

From Dave Cramer
Subject Re: Request for comment on setting binary format output per session
Date
Msg-id CADK3HHKbWEnbY07OAh1wuSr8HYSx-mYuUTCsit6DMFeEZSaeew@mail.gmail.com
Whole thread Raw
In response to Re: Request for comment on setting binary format output per session  (Merlin Moncure <mmoncure@gmail.com>)
Responses Re: Request for comment on setting binary format output per session
List pgsql-hackers
Tree view



On Mon, 24 Apr 2023 at 19:18, Merlin Moncure <mmoncure@gmail.com> wrote:


On Thu, Apr 20, 2023 at 2:52 PM Dave Cramer <davecramer@gmail.com> wrote:

As promised here is a patch with defines for all of the protocol messages.
I created a protocol.h file and put it in src/includes
I'm fairly sure that some of the names I used may need to be changed but the grunt work of finding and replacing everything is done.

In many cases, converting inline character to macro eliminates the need for inline comment, e.g.:
+ case SIMPLE_QUERY: /* simple query */

...that's more work obviously, do you agree and if so would you like some help going through that?

I certainly agree. I left them there mostly for reviewers. I expected some minor adjustments to names of the macro's

So if you have suggestions I'll make changes. 

I'll remove the comments if they are no longer necessary.

Dave 

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: ssl tests aren't concurrency safe due to get_free_port()
Next
From: Daniel Gustafsson
Date:
Subject: Re: Should vacuum process config file reload more often