Re: [POC] A better way to expand hash indexes. - Mailing list pgsql-hackers

On Tue, Apr 4, 2017 at 9:18 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> Committed.

Thanks Robert,

And also sorry, one unfortunate thing happened in the last patch while
fixing one of the review comments a variable disappeared from the
equation
@_hash_spareindex.

        splitpoint_phases +=
-               (((num_bucket - 1) >> (HASH_SPLITPOINT_PHASE_BITS + 1)) &
+               (((num_bucket - 1) >>
+                 (splitpoint_group - (HASH_SPLITPOINT_PHASE_BITS + 1))) &
                 HASH_SPLITPOINT_PHASE_MASK);   /* to 0-based value. */

I wanted most significant 3 bits. And while fixing comments in patch11
I unknowingly somehow removed splitpoint_group from the equation.
Extremely sorry for the mistake. Thanks to Ashutosh Sharma for
pointing the mistake.


-- 
Thanks and Regards
Mithun C Y
EnterpriseDB: http://www.enterprisedb.com